post meta - update_post_meta() not working when used with WordPress action-369IT编程

admin管理员组
文章数量:1130349

I am trying to update the field when post status changes to published. It is getting the values properly but not updating when I check the what update field is returning.

It shows some number.

Please help not sure whether I should use this along with transition_post_status

Update - I have tried below hooks // the action is getting triggered but the fields are not updating

1. publish //works but no update is happening

2. save_post && save_post_l //works but no update is happening.

add_action('transition_post_status', 'updated_to_publish', 10, 3);
function updated_to_publish($new_status, $old_status, $post)
{

    if ($new_status == 'publish')) // I have removed the check for post type 
  {

        $post_id = $post->ID;

        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $metatitle = get_field('seo_title', $post_id);
                $metadesc = get_field('seo_meta_description', $post_id);
                $metakeywords = get_field('seo_keyword', $post_id);


                update_post_meta($post_id, '_yoast_wpseo_title', $metatitle );
                update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc );
                update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords);

            }

        }

    } else {
        return;
    }

}

Update

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

code that i used for testing

add_action('transition_post_status', 'updated_to_publish', 10, 3);
    function updated_to_publish($new_status, $old_status, $post)
    {

        if (($new_status == 'publish') && ($post->post_type == 'l')) {

            $post_id = $post->ID;

            error_log( var_export( $post_id, 1 ) );

            if (get_field('advanced_option_edit_seo', $post_id)) {


                if (defined('WPSEO_VERSION')) {

                    // ACF field
                    $metatitle    = get_field('seo_title', $post_id);

                     error_log( var_export( $metatitle, 1 ) );

                    $metadesc     = get_field('seo_meta_description', $post_id);

                     error_log( var_export( $metadesc, 1 ) );
                    $metakeywords = get_field('seo_keyword', $post_id);

                     error_log( var_export( $metakeywords, 1 ) );
                    //plugin is activated


                    //old values 

                     $metadesc_old = get_post_meta($post->ID, '_yoast_wpseo_metadesc', true);
                        error_log( var_export( $metadesc_old, 1 ) );
                     $metatitle_old = get_post_meta($post->ID, '_yoast_wpseo_title', true);
                         error_log( var_export( $metatitle_old, 1 ) );
                     $metakeywords_old = get_post_meta($post->ID, '_yoast_wpseo_focuskw', true);
                        error_log( var_export( $metakeywords_old, 1 ) );

                    update_post_meta($post_id, '_yoast_wpseo_title', $metatitle, $metatitle_old);
                       error_log( var_export( $tyone, 1 ) );
                   update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc, $metadesc_old);
                       error_log( var_export( $tytwo, 1 ) );
                     update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords, $metakeywords_old);  
                       error_log( var_export( $tythree, 1 ) ); 

                }

            }

        } else {
            return;
        }

        //Do something
    }

I am trying to update the field when post status changes to published. It is getting the values properly but not updating when I check the what update field is returning.

It shows some number.

Please help not sure whether I should use this along with transition_post_status

Update - I have tried below hooks // the action is getting triggered but the fields are not updating

1. publish //works but no update is happening

2. save_post && save_post_l //works but no update is happening.

add_action('transition_post_status', 'updated_to_publish', 10, 3);
function updated_to_publish($new_status, $old_status, $post)
{

    if ($new_status == 'publish')) // I have removed the check for post type 
  {

        $post_id = $post->ID;

        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $metatitle = get_field('seo_title', $post_id);
                $metadesc = get_field('seo_meta_description', $post_id);
                $metakeywords = get_field('seo_keyword', $post_id);


                update_post_meta($post_id, '_yoast_wpseo_title', $metatitle );
                update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc );
                update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords);

            }

        }

    } else {
        return;
    }

}

Update

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

code that i used for testing

add_action('transition_post_status', 'updated_to_publish', 10, 3);
    function updated_to_publish($new_status, $old_status, $post)
    {

        if (($new_status == 'publish') && ($post->post_type == 'l')) {

            $post_id = $post->ID;

            error_log( var_export( $post_id, 1 ) );

            if (get_field('advanced_option_edit_seo', $post_id)) {


                if (defined('WPSEO_VERSION')) {

                    // ACF field
                    $metatitle    = get_field('seo_title', $post_id);

                     error_log( var_export( $metatitle, 1 ) );

                    $metadesc     = get_field('seo_meta_description', $post_id);

                     error_log( var_export( $metadesc, 1 ) );
                    $metakeywords = get_field('seo_keyword', $post_id);

                     error_log( var_export( $metakeywords, 1 ) );
                    //plugin is activated


                    //old values 

                     $metadesc_old = get_post_meta($post->ID, '_yoast_wpseo_metadesc', true);
                        error_log( var_export( $metadesc_old, 1 ) );
                     $metatitle_old = get_post_meta($post->ID, '_yoast_wpseo_title', true);
                         error_log( var_export( $metatitle_old, 1 ) );
                     $metakeywords_old = get_post_meta($post->ID, '_yoast_wpseo_focuskw', true);
                        error_log( var_export( $metakeywords_old, 1 ) );

                    update_post_meta($post_id, '_yoast_wpseo_title', $metatitle, $metatitle_old);
                       error_log( var_export( $tyone, 1 ) );
                   update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc, $metadesc_old);
                       error_log( var_export( $tytwo, 1 ) );
                     update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords, $metakeywords_old);  
                       error_log( var_export( $tythree, 1 ) ); 

                }

            }

        } else {
            return;
        }

        //Do something
    }

Share Improve this question edited Nov 14, 2018 at 13:38 asked Nov 8, 2018 at 16:58 user145078

1 you say when i check the what update field is returning it shows some number, that is the ID of the metadata it just inserted, this means it has worked. From the documentation: Return: Meta ID if the key didn't exist, true on successful update, false on failure. – Milo Commented Nov 10, 2018 at 17:17
@Milo But when i check it after updating the meta fields they are empty. Yes but all the update field returns a number(ID). Not sure if i am using correct action. – user145078 Commented Nov 10, 2018 at 17:27
@Milo the issue was with action . every thing works if i use wp_insert_post – user145078 Commented Nov 11, 2018 at 22:07
1 If (you're 100% sure) the fields are not being updated, and you did get to the update_post_meta() part, then some possible causes are: a) the fields are already updated (i.e. new values equal the current values in the database, so update_post_meta() will update nothing); or b) a plugin/code is changing back (or removing) the field values. With the wp_insert_post action, the fields may have yet existed in the post being created/updated; hence that's likely why the update_post_meta() calls work. – Sally CJ Commented Nov 13, 2018 at 12:20
1 @LatheeshVMVilla, try using a test field - update_post_meta( $post_id, 'test20181114', 'Test 20181114' ); - and see if the field is being added to the post. If it is, then your code works. PS: In my previous comment, I meant to say "When you tested with the wp_insert_post action". – Sally CJ Commented Nov 14, 2018 at 10:49

| Show 12 more comments

3 Answers 3

Sorted by: Reset to default 1 +50

So I installed the Yoast SEO plugin, and tested your code, and now I can positively say "neither no nor yes, but you could" to this question:

Please help not sure whether I should use this along with transition_post_status

transition_post_status is fired before the wp_insert_post action is fired, and the Yoast SEO plugin is actually saving (adding/updating) all its custom fields via the wp_insert_post action:

// See WPSEO_Metabox::save_postdata() (in wordpress-seo/admin/metabox/class-metabox.php)
add_action( 'wp_insert_post', array( $this, 'save_postdata' ) );

So your code itself works, and the fields do get updated (if the new and current values are not the same and that all the if conditions are met, of course); however the Yoast SEO plugin overrides the value via the WPSEO_Metabox::save_postdata() function, which should answer this question:

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

Why did I say neither no nor yes, but you could?

Because you can use transition_post_status along with wp_insert_post like so:

add_action( 'transition_post_status', 'do_updated_to_publish', 10, 2 );
function do_updated_to_publish( $new_status, $old_status ) {
    if ( $new_status !== $old_status && 'publish' === $new_status ) {
        add_action( 'wp_insert_post', 'updated_to_publish', 10, 2 );
    }
}

function updated_to_publish( $post_id, $post ) {
    // Remove it; it will be re-added via the do_updated_to_publish() function,
    // if necessary or when applicable.
    remove_action( 'wp_insert_post', 'updated_to_publish', 10, 2 );

    if ( ! defined( 'WPSEO_VERSION' ) || 'l' !== $post->post_type ) {
        return;
    }

    if ( get_field( 'advanced_option_edit_seo', $post_id ) ) {
        // Make your update_post_meta() calls here.
        update_post_meta( $post_id, '_yoast_wpseo_focuskw', 'test' );
        error_log( 'focuskw updated for post #' . $post_id );
    }
}

Tried and tested working with Yoast SEO version 9.1.

try "wpseo_title" Filter for updating wpseo_title.

add_filter('wpseo_title', 'filter_product_wpseo_title');

function filter_product_wpseo_title($title) {
global $post;
$post_id = $post->ID;
        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $title = get_field('seo_title', $post_id);

            }

        }


    return $title;
}

for more seo data update example: https://yoast/wordpress/plugins/seo/api/

Your original function relies on the $_POST['post_type'] being set to the appropriate value. As a general rule, you should avoid using global variables - if you use only want the function gives to you, you don't have to think about the contexts in what it should be called.

In this case, that's what's happened. You're function relies on a global variable $_POST['post_type'], and while that works in one 'state' (publishing a post) it doesn't in another (a cron job, updating a post). In short, $_POST['post_type'] isn't always what you think it should be.

The following retrieves the post type from the passed $post variable:

add_action('transition_post_status', 'updated_to_publish', 10, 3);

function updated_to_publish($new_status, $old_status, $post) {

if (($new_status == 'publish') && (get_post_type( $post ) == 'l')) {

    $post_id = $post->ID;

    if (get_field('advanced_option_edit_seo', $post_id)) {

        if (defined('WPSEO_VERSION')) {

           //Code goes here

        }
    }

} else {
    return;
}

}

Visit this link from where I just have copied the answer

I am trying to update the field when post status changes to published. It is getting the values properly but not updating when I check the what update field is returning.

It shows some number.

Please help not sure whether I should use this along with transition_post_status

Update - I have tried below hooks // the action is getting triggered but the fields are not updating

1. publish //works but no update is happening

2. save_post && save_post_l //works but no update is happening.

add_action('transition_post_status', 'updated_to_publish', 10, 3);
function updated_to_publish($new_status, $old_status, $post)
{

    if ($new_status == 'publish')) // I have removed the check for post type 
  {

        $post_id = $post->ID;

        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $metatitle = get_field('seo_title', $post_id);
                $metadesc = get_field('seo_meta_description', $post_id);
                $metakeywords = get_field('seo_keyword', $post_id);


                update_post_meta($post_id, '_yoast_wpseo_title', $metatitle );
                update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc );
                update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords);

            }

        }

    } else {
        return;
    }

}

Update

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

code that i used for testing

add_action('transition_post_status', 'updated_to_publish', 10, 3);
    function updated_to_publish($new_status, $old_status, $post)
    {

        if (($new_status == 'publish') && ($post->post_type == 'l')) {

            $post_id = $post->ID;

            error_log( var_export( $post_id, 1 ) );

            if (get_field('advanced_option_edit_seo', $post_id)) {


                if (defined('WPSEO_VERSION')) {

                    // ACF field
                    $metatitle    = get_field('seo_title', $post_id);

                     error_log( var_export( $metatitle, 1 ) );

                    $metadesc     = get_field('seo_meta_description', $post_id);

                     error_log( var_export( $metadesc, 1 ) );
                    $metakeywords = get_field('seo_keyword', $post_id);

                     error_log( var_export( $metakeywords, 1 ) );
                    //plugin is activated


                    //old values 

                     $metadesc_old = get_post_meta($post->ID, '_yoast_wpseo_metadesc', true);
                        error_log( var_export( $metadesc_old, 1 ) );
                     $metatitle_old = get_post_meta($post->ID, '_yoast_wpseo_title', true);
                         error_log( var_export( $metatitle_old, 1 ) );
                     $metakeywords_old = get_post_meta($post->ID, '_yoast_wpseo_focuskw', true);
                        error_log( var_export( $metakeywords_old, 1 ) );

                    update_post_meta($post_id, '_yoast_wpseo_title', $metatitle, $metatitle_old);
                       error_log( var_export( $tyone, 1 ) );
                   update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc, $metadesc_old);
                       error_log( var_export( $tytwo, 1 ) );
                     update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords, $metakeywords_old);  
                       error_log( var_export( $tythree, 1 ) ); 

                }

            }

        } else {
            return;
        }

        //Do something
    }

I am trying to update the field when post status changes to published. It is getting the values properly but not updating when I check the what update field is returning.

It shows some number.

Please help not sure whether I should use this along with transition_post_status

Update - I have tried below hooks // the action is getting triggered but the fields are not updating

1. publish //works but no update is happening

2. save_post && save_post_l //works but no update is happening.

add_action('transition_post_status', 'updated_to_publish', 10, 3);
function updated_to_publish($new_status, $old_status, $post)
{

    if ($new_status == 'publish')) // I have removed the check for post type 
  {

        $post_id = $post->ID;

        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $metatitle = get_field('seo_title', $post_id);
                $metadesc = get_field('seo_meta_description', $post_id);
                $metakeywords = get_field('seo_keyword', $post_id);


                update_post_meta($post_id, '_yoast_wpseo_title', $metatitle );
                update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc );
                update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords);

            }

        }

    } else {
        return;
    }

}

Update

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

code that i used for testing

add_action('transition_post_status', 'updated_to_publish', 10, 3);
    function updated_to_publish($new_status, $old_status, $post)
    {

        if (($new_status == 'publish') && ($post->post_type == 'l')) {

            $post_id = $post->ID;

            error_log( var_export( $post_id, 1 ) );

            if (get_field('advanced_option_edit_seo', $post_id)) {


                if (defined('WPSEO_VERSION')) {

                    // ACF field
                    $metatitle    = get_field('seo_title', $post_id);

                     error_log( var_export( $metatitle, 1 ) );

                    $metadesc     = get_field('seo_meta_description', $post_id);

                     error_log( var_export( $metadesc, 1 ) );
                    $metakeywords = get_field('seo_keyword', $post_id);

                     error_log( var_export( $metakeywords, 1 ) );
                    //plugin is activated


                    //old values 

                     $metadesc_old = get_post_meta($post->ID, '_yoast_wpseo_metadesc', true);
                        error_log( var_export( $metadesc_old, 1 ) );
                     $metatitle_old = get_post_meta($post->ID, '_yoast_wpseo_title', true);
                         error_log( var_export( $metatitle_old, 1 ) );
                     $metakeywords_old = get_post_meta($post->ID, '_yoast_wpseo_focuskw', true);
                        error_log( var_export( $metakeywords_old, 1 ) );

                    update_post_meta($post_id, '_yoast_wpseo_title', $metatitle, $metatitle_old);
                       error_log( var_export( $tyone, 1 ) );
                   update_post_meta($post_id, '_yoast_wpseo_metadesc', $metadesc, $metadesc_old);
                       error_log( var_export( $tytwo, 1 ) );
                     update_post_meta($post_id, '_yoast_wpseo_focuskw', $metakeywords, $metakeywords_old);  
                       error_log( var_export( $tythree, 1 ) ); 

                }

            }

        } else {
            return;
        }

        //Do something
    }

Share Improve this question edited Nov 14, 2018 at 13:38 asked Nov 8, 2018 at 16:58 user145078

1 you say when i check the what update field is returning it shows some number, that is the ID of the metadata it just inserted, this means it has worked. From the documentation: Return: Meta ID if the key didn't exist, true on successful update, false on failure. – Milo Commented Nov 10, 2018 at 17:17
@Milo But when i check it after updating the meta fields they are empty. Yes but all the update field returns a number(ID). Not sure if i am using correct action. – user145078 Commented Nov 10, 2018 at 17:27
@Milo the issue was with action . every thing works if i use wp_insert_post – user145078 Commented Nov 11, 2018 at 22:07
1 If (you're 100% sure) the fields are not being updated, and you did get to the update_post_meta() part, then some possible causes are: a) the fields are already updated (i.e. new values equal the current values in the database, so update_post_meta() will update nothing); or b) a plugin/code is changing back (or removing) the field values. With the wp_insert_post action, the fields may have yet existed in the post being created/updated; hence that's likely why the update_post_meta() calls work. – Sally CJ Commented Nov 13, 2018 at 12:20
1 @LatheeshVMVilla, try using a test field - update_post_meta( $post_id, 'test20181114', 'Test 20181114' ); - and see if the field is being added to the post. If it is, then your code works. PS: In my previous comment, I meant to say "When you tested with the wp_insert_post action". – Sally CJ Commented Nov 14, 2018 at 10:49

| Show 12 more comments

3 Answers 3

Sorted by: Reset to default 1 +50

So I installed the Yoast SEO plugin, and tested your code, and now I can positively say "neither no nor yes, but you could" to this question:

Please help not sure whether I should use this along with transition_post_status

transition_post_status is fired before the wp_insert_post action is fired, and the Yoast SEO plugin is actually saving (adding/updating) all its custom fields via the wp_insert_post action:

// See WPSEO_Metabox::save_postdata() (in wordpress-seo/admin/metabox/class-metabox.php)
add_action( 'wp_insert_post', array( $this, 'save_postdata' ) );

I was able to solve the issue by using 'wp_insert_post' action . Can I know why other actions failed but 'wp_insert_post' worked?

Why did I say neither no nor yes, but you could?

Because you can use transition_post_status along with wp_insert_post like so:

add_action( 'transition_post_status', 'do_updated_to_publish', 10, 2 );
function do_updated_to_publish( $new_status, $old_status ) {
    if ( $new_status !== $old_status && 'publish' === $new_status ) {
        add_action( 'wp_insert_post', 'updated_to_publish', 10, 2 );
    }
}

function updated_to_publish( $post_id, $post ) {
    // Remove it; it will be re-added via the do_updated_to_publish() function,
    // if necessary or when applicable.
    remove_action( 'wp_insert_post', 'updated_to_publish', 10, 2 );

    if ( ! defined( 'WPSEO_VERSION' ) || 'l' !== $post->post_type ) {
        return;
    }

    if ( get_field( 'advanced_option_edit_seo', $post_id ) ) {
        // Make your update_post_meta() calls here.
        update_post_meta( $post_id, '_yoast_wpseo_focuskw', 'test' );
        error_log( 'focuskw updated for post #' . $post_id );
    }
}

Tried and tested working with Yoast SEO version 9.1.

try "wpseo_title" Filter for updating wpseo_title.

add_filter('wpseo_title', 'filter_product_wpseo_title');

function filter_product_wpseo_title($title) {
global $post;
$post_id = $post->ID;
        if (get_field('advanced_option_edit_seo', $post_id)) {

            if (defined('WPSEO_VERSION')) {

                $title = get_field('seo_title', $post_id);

            }

        }


    return $title;
}

for more seo data update example: https://yoast/wordpress/plugins/seo/api/

The following retrieves the post type from the passed $post variable:

add_action('transition_post_status', 'updated_to_publish', 10, 3);

function updated_to_publish($new_status, $old_status, $post) {

if (($new_status == 'publish') && (get_post_type( $post ) == 'l')) {

    $post_id = $post->ID;

    if (get_field('advanced_option_edit_seo', $post_id)) {

        if (defined('WPSEO_VERSION')) {

           //Code goes here

        }
    }

} else {
    return;
}

}

Visit this link from where I just have copied the answer

本文标签： post metaupdatepostmeta() not working when used with WordPress action

版权声明：本文标题：post meta - update_post_meta() not working when used with WordPress action 内容由热心网友自发贡献，该文观点仅代表作者本人，转载请联系作者并注明出处：https://it.en369.cn/questions/1749181190a2328636.html，本站仅提供信息存储空间服务，不拥有所有权，不承担相关法律责任。如发现本站有涉嫌抄袭侵权/违法违规的内容，一经查实，本站将立刻删除。

369IT编程

post meta - update_post_meta() not working when used with WordPress action

Update

Update

3 Answers 3

Update

Update

3 Answers 3

更多相关文章

post meta - update_post_meta() not working when used with WordPress action

发表评论

推荐文章

vmware12虚拟机中ubuntu16.04安装搜狗输入法

【PC桌面软件的末日，手机移动端App称王】写在windows11支持安卓，macOS支持ios，龙芯支持x86和arm指令翻译

抖音直播间截流软件

教育部计算机英语怎么说,教育部课题、国家社科基金、国家自然基金的英文翻译？？？...

计算机游戏cpu,玩游戏选什么CPU 10款2017适合玩游戏的处理器推荐 (全文)

热门文章

记录：URI、URL和Uri

提取机器人专注视频号视频下载！视频号视频下载使用教程

ChatGPT is Not Available in Your Country 解决方案

【亲测免费】 计算机辅助设计软件AutoCAD 2024版本在Windows系统的下载与安装配置指南

Docker: windows下跑windows镜像

探索SOPS：加密文件管理的新纪元

windows系统（WIN10） 安装JDK

Windows系统空文件夹清理大师.zip

离线翻译软件哪款好用？这5款离线翻译软件很实用

2025 年六大主流智能体平台深度测评：从技术原理到场景落地的全景透视（万字博文深度测评）

最新文章

Sublime 32位 激活码

windows下载安装远程桌面工具RealVNC-Server教程(RealVNC_E4_6_1版带注册码)

【亲测免费】 抖音直播伴侣推流密钥获取工具使用教程

【亲测免费】 Proxifer 安装包与注册码

Royal TSX许可证密钥(6.x后所有版本都可以用)

程序员刚毕业，先去大厂镀金还是先去小厂攒经验？

万象2008清空boss账户密码

【Tools】GitBook简明教程

oracle exadata celldisk 闪存盘受损导致性能下降

SDUT 2138 图结构练习——BFSDFS——判断可达性

WordPress get parent category taxonomy

Omit specific product categories from WooCommerce shortcode

Updating Posts table in database without overwriting user generated content

php - Use wp_get_recent_posts with search term

responsive - How to exclude an image size from the Wordpress srcset

【亲测免费】计算机辅助设计软件AutoCAD 2024版本在Windows系统的下载与安装配置指南

windows系统（WIN10）安装JDK

Sublime 32位激活码

【亲测免费】抖音直播伴侣推流密钥获取工具使用教程